Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 'cosign sign' add flags --ca-roots and --ca-intermediates to allow multiple CA roots #3568

Open
dmitris opened this issue Feb 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dmitris
Copy link
Contributor

dmitris commented Feb 29, 2024

Description
This is continuation of the work started in #3462 but with cosign sign instead of cosign verify. All the rationale applies - the goal is to allow to run cosign sign with the multiple roots of trust in a single certificate bundle file, passed through the new --ca-roots flag (as well as the optional intermediates - with the --ca-intermediates).
The second goal is to extend the exposed Go data structures to allow the clients using sigstore/cosign as a Go library to perform the signing while passing the "roots of trust" certificate bundle file. I suggest to add new fields, CARoots and CAIntermediates to the SignOptions after Cert and CertChain:

type SignOptions struct {
	Key             string
	Cert            string
	CertChain       string
        CARoots         string
        CAIntermediates string
	Upload          bool
        [...]
}
@dmitris dmitris added the enhancement New feature or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant