update release images to use go1.19.2 and cosign v1.12.1 #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cpanato <ctadeu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage 30.06% 30.06%
=======================================
Files 131 131
Lines 8062 8062
=======================================
Hits 2424 2424
Misses 5314 5314
Partials 324 324 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlorenc
previously approved these changes
Oct 6, 2022
|
Question: should we set 1.19 here too https://github.com/sigstore/cosign/blob/main/go.mod#L3 ? |
we are not doing this right now because downstream users that are using go1.18 can import the module, otherwise, they need to upgrade to 1.19 |
developer-guy
previously approved these changes
Oct 6, 2022
Signed-off-by: cpanato <ctadeu@gmail.com>
cpanato
force-pushed
the
udpate-release-images
branch
from
f4da8b0
to
4012377
Compare
developer-guy
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary