Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better help text to sign and verify SBOM #2308

Merged
merged 1 commit into from Oct 4, 2022
Merged

Conversation

ChristianCiach
Copy link
Contributor

#615 introduced easier ways to sign and verify sbom images, but didn't document them.

This PR nudges users to these new options and also replaces the deprecated -key and -predicate options with their modern double-dash variants.

@cpanato
Copy link
Member

cpanato commented Oct 4, 2022

thanks for this PR, can you please sign the DCO

Signed-off-by: Christian Ciach <christian.ciach@emsysgrid.de>
@codecov-commenter
Copy link

Codecov Report

Merging #2308 (8bab284) into main (1370afe) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   29.57%   29.57%           
=======================================
  Files         131      131           
  Lines        8044     8044           
=======================================
  Hits         2379     2379           
  Misses       5348     5348           
  Partials      317      317           
Impacted Files Coverage Δ
cmd/cosign/cli/attach.go 0.00% <0.00%> (ø)
cmd/cosign/cli/download.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants