fix: fixing breaking changes in rekor v1.12.0 upgrade #2260
Conversation
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
| return types.NewProposedEntry(ctx, intoto.KIND, intoto_v001.APIVERSION, types.ArtifactProperties{ | ||
| ArtifactBytes: signature, | ||
| PublicKeyBytes: pubKey, | ||
| PublicKeyBytes: pubKeyBytes, |
There was a problem hiding this comment.
had to check up on why the rekorEntry function here that reconstructs hashedrekord types didn't need to be changed: that directly creates a v0.0.1 hashed rekord type, instead of relying on the general entry construction.
|
Just ran into a problem that we can't generate a rekor entry for testing for intoto v0.0.1 at 0.12.0 because v0.0.1 intoto was explicitly not supported. We need Priya's fix here: sigstore/rekor@a6d36b8 |
Signed-off-by: Asra Ali <asraa@google.com>
|
I think you may have branch protection on! (didn't expect anything less!) But this PR is updated with two commits in my fork: https://github.com/asraa/cosign/tree/fix-rekorv112 |
Codecov Report
@@ Coverage Diff @@
## main #2260 +/- ##
==========================================
- Coverage 28.56% 28.54% -0.03%
==========================================
Files 131 131
Lines 7855 7866 +11
==========================================
+ Hits 2244 2245 +1
- Misses 5305 5314 +9
- Partials 306 307 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
fix/rekor-v112-upgrade
branch
from
a74dd99
to
4621231
Compare
|
Is this one ready to go @asraa ? |
|
This is blocking 0.12 rolling out to prod, so this should be prioritized. |
what still needs to happen here? cc @asraa ? |
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
This PR aims to fix breaking changes in Rekor v1.12.0 pkg
Summary
Release Note
Documentation
/cc @priyawadhwa