Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework fig autocomplete command #2187

Merged
merged 1 commit into from Aug 22, 2022
Merged

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Aug 20, 2022

Signed-off-by: Engin Diri engin.diri@mail.schwarz

Summary

This PR creates the first part of the steps described here #2186

Adding @developer-guy, as he created the first iteration of the fig integration.

Release Note

NONE

Documentation

NONE

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #2187 (6c4f607) into main (8f29f03) will increase coverage by 0.65%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   26.03%   26.69%   +0.65%     
==========================================
  Files         131      131              
  Lines        7689     7690       +1     
==========================================
+ Hits         2002     2053      +51     
+ Misses       5445     5376      -69     
- Partials      242      261      +19     
Impacted Files Coverage Δ
cmd/cosign/cli/commands.go 0.00% <0.00%> (ø)
pkg/blob/load.go 74.28% <0.00%> (+5.71%) ⬆️
pkg/oci/layout/index.go 28.57% <0.00%> (+28.57%) ⬆️
pkg/oci/layout/write.go 37.50% <0.00%> (+37.50%) ⬆️
pkg/oci/layout/signatures.go 53.84% <0.00%> (+53.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
Lgtm

@cpanato cpanato merged commit e8b3c71 into sigstore:main Aug 22, 2022
@github-actions github-actions bot added this to the v1.12.0 milestone Aug 22, 2022
@dirien dirien deleted the fig-command branch August 23, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants