Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vet and update the required tests. #2154

Closed
vaikas opened this issue Aug 12, 2022 · 2 comments · Fixed by sigstore/community#99
Closed

Vet and update the required tests. #2154

vaikas opened this issue Aug 12, 2022 · 2 comments · Fixed by sigstore/community#99
Assignees
Labels
bug Something isn't working

Comments

@vaikas
Copy link
Contributor

vaikas commented Aug 12, 2022

Description
We should go through the required tests here:
https://github.com/sigstore/community/blob/main/github-sync/github-data/repositories.yaml#L137

And figure out what are real required tests that must pass before a commit is merged. Right now it looks a bit light :)

        statusChecks:
          - DCO

I think this is a problem since PRs that have failing tests will merge, especially if folks use 'enable auto-merge' and expect that the PR will not merge if all the tests pass.

And indeed, it seems that for example, here's one that had failures but was merged.
#2150
https://github.com/sigstore/cosign/runs/7791224163?check_suite_focus=true

Or here:
https://github.com/sigstore/cosign/pull/2071/checks
That had bunch of failures.

https://github.com/sigstore/cosign/actions/runs/2671639620

Version
HEAD

@vaikas vaikas added the bug Something isn't working label Aug 12, 2022
@dlorenc
Copy link
Member

dlorenc commented Aug 14, 2022

Ugh, the failures are expected on the dependabot PRs. The e2e tests run with secrets, and shouldn't run at all on PRs. But dependabot somehow triggers PRs that look as if they were pushed to the main fork, but don't have access to the secrets. We need to just stop those from running if it's a dependabot PR.

@cpanato
Copy link
Member

cpanato commented Aug 16, 2022

updated the repo and add the config in the automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants