Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --skip-information flag to clean cmd for consistency #2044

Open
developer-guy opened this issue Jul 4, 2022 · 3 comments
Open

add --skip-information flag to clean cmd for consistency #2044

developer-guy opened this issue Jul 4, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@developer-guy
Copy link
Member

Description

Based on the talk in Slack1 with @imjasonh, it'd be better for consistency to use the skip-information flag for clean cmd in addition to the force flag.

The whole UX would be like the following:

  1. We'll probably want --force to continue to exist for 1+ release, with a warning that it's renamed to --skip-confirmation.
  2. use --force's value to set o.SkipConfirmation.
  3. If both are set and they disagree, then fail.

Footnotes

  1. https://github.com/sigstore/cosign/pull/2039#discussion_r911985088

@developer-guy developer-guy added the enhancement New feature or request label Jul 4, 2022
@developer-guy
Copy link
Member Author

@dentraz would you like to give this one a hand?

@znewman01
Copy link
Contributor

CC @haydentherapper; see also #1909 and my comments therein

Before a rename I'd really like to see some documentation (comments in the code would be sufficient) about our prompting philosophy first. I think it's really useful to have (1) consistent principles for flag naming, prompting, etc. across the tool and (2) communicate those to users, so they know what to expect.

I also prefer --force as a flag name because I don't want bespoke flags per each acknowledgment but I wouldn't put up a fight about it.

@znewman01
Copy link
Contributor

Also I think you wanted @Dentrax :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants