Revert "Refactor fulcio signer to take in KeyOpts. (#1788)" #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing DCO. |
This reverts commit 8368bad. Signed-off-by: Billy Lynch <billy@chainguard.dev>
🤦 Fixed! |
dlorenc
approved these changes
Apr 25, 2022
|
thanks! |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…igstore#1798) This reverts commit 8368bad. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 8368bad which started causing e2e failures in https://github.com/sigstore/cosign/runs/6142999072?check_suite_focus=true.
Will look fixing this in the next few days, but rolling back for now to get the tests green again.
Ticket Link
part of #1788
Release Note