add use-sudo optional parameter defaulting to false. Fixes: #85

[jsolis]

Summary

Adds optional input use-sudo that can be set to true in the case that install-dir requires sudo privs. The reason for this is that always using sudo actually broke our self-hosted runners since the user the runner runs as doesn't have sudo privs by security design.

Ticket Link

Fixes #85

Release Note

* adds `use-sudo` optional input which defaults to false

[cpanato]

thanks for the PR, just a minor comments

[jsolis]

The one failing test failed for cosign: error while loading shared libraries: libpcsclite.so.1: cannot open shared object file: No such file or directory when testing cosign 0.6.0. I don't believe my changes would have caused this 🤔

[cpanato]

The one failing test failed for cosign: error while loading shared libraries: libpcsclite.so.1: cannot open shared object file: No such file or directory when testing cosign 0.6.0. I don't believe my changes would have caused this 🤔

The one failing test failed for cosign: error while loading shared libraries: libpcsclite.so.1: cannot open shared object file: No such file or directory when testing cosign 0.6.0. I don't believe my changes would have caused this 🤔

kind of, because that to install the lib it needs the sudo and now it is not setting

INFO: libpcsclite1 package is not installed, installing it now.
E: Could not open lock file /var/lib/apt/lists/lock - open (13: Permission denied)
E: Unable to lock directory /var/lib/apt/lists/
W: Problem unlinking the file /var/cache/apt/pkgcache.bin - RemoveCaches (13: Permission denied)
W: Problem unlinking the file /var/cache/apt/srcpkgcache.bin - RemoveCaches (13: Permission denied)
E: Could not open lock file /var/lib/dpkg/lock-frontend - open (13: Permission denied)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), are you root?

in this part: https://github.com/sigstore/cosign-installer/blob/main/action.yml#L208-L223
we might need to add the sudo back here

[jsolis]

in this part: https://github.com/sigstore/cosign-installer/blob/main/action.yml#L208-L223 we might need to add the sudo back here

Yep ok, I'll fix this. I should have paid more attention to this failure, sorry about that.

[jsolis]

OK, I can see from before the sudo changes were made, that block of code always used sudo and my new changes broke that. I have put back the sudo commands instead of using $SUDO. All tests are now passing on my fork.

[cpanato]

thank you!