Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo mv the cosign binary to the install-dir #83

Merged
merged 1 commit into from Jun 22, 2022

Conversation

saschagrunert
Copy link
Contributor

Summary

We cannot use install-dirs like /usr/bin/cosign right now because
this would cause an permission denied error. To be able to use those
paths we have to run mv and chmod via root.

Ticket Link

None

Release Note

Fixed `install-dir` locations to work when they require root access (for example `/usr/bin/cosign`.

action.yml Outdated Show resolved Hide resolved
@saschagrunert
Copy link
Contributor Author

@cpanato another try please 😇

@saschagrunert saschagrunert changed the title sudo mv the cosign binary to the install-dir WIP: sudo mv the cosign binary to the install-dir Jun 22, 2022
We cannot use `install-dir`s like `/usr/bin/cosign` right now because
this would cause an permission denied error. To be able to use those
paths we have to run `mv` and `chmod` via root.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert changed the title WIP: sudo mv the cosign binary to the install-dir sudo mv the cosign binary to the install-dir Jun 22, 2022
@saschagrunert
Copy link
Contributor Author

Ready for another round

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the improvement!

@cpanato cpanato merged commit 441a29e into sigstore:main Jun 22, 2022
@saschagrunert saschagrunert deleted the sudo branch June 22, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants