Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin github actions in test harness #50

Merged
merged 1 commit into from Jan 12, 2022
Merged

Conversation

bobcallaway
Copy link
Member

Addressing https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies

data from running scorecard --show-details --repo=https://github.com/sigstore/cosign-installer/ --checks Pinned-Dependencies --format json:

{
  "date": "2022-01-12",
  "repo": {
    "name": "github.com/sigstore/cosign-installer",
    "commit": "fb055c05fad51114678995df1accc3adf0525baf"
  },
  "scorecard": {
    "version": "b79b3c3",
    "commit": "b79b3c357c99a38afabbdbdab1047c15c0db4afd"
  },
  "score": 8,
  "checks": [
    {
      "details": [
        "Warn: GitHub-owned action not pinned by hash: .github/workflows/test-action.yml:24",
        "Warn: GitHub-owned action not pinned by hash: .github/workflows/test-action.yml:58",
        "Warn: third-party action not pinned by hash: .github/workflows/test-action.yml:60",
        "Warn: GitHub-owned action not pinned by hash: .github/workflows/test-action.yml:90",
        "Warn: GitHub-owned action not pinned by hash: .github/workflows/test-action.yml:125",
        "Warn: GitHub-owned action not pinned by hash: .github/workflows/test-action.yml:161",
        "Warn: GitHub-owned action not pinned by hash: .github/workflows/test-action.yml:199",
        "Warn: GitHub-owned action not pinned by hash: .github/workflows/test-action.yml:224",
        "Info: Dockerfile dependencies are pinned",
        "Info: no insecure (not pinned by hash) dependency downloads found in Dockerfiles",
        "Info: no insecure (not pinned by hash) dependency downloads found in shell scripts",
        "Info: no insecure (not pinned by hash) dependency downloads found in GitHub workflows"
      ],
      "score": 8,
      "reason": "dependency not pinned by hash detected -- score normalized to 8",
      "name": "Pinned-Dependencies",
      "documentation": {
        "url": "https://github.com/ossf/scorecard/blob/b79b3c357c99a38afabbdbdab1047c15c0db4afd/docs/checks.md#pinned-dependencies",
        "short": "Determines if the project has declared and pinned its dependencies."
      }
    }
  ],
  "metadata": null
}

Signed-off-by: Bob Callaway bob.callaway@gmail.com

Summary

Ticket Link

Fixes

Release Note


Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@cpanato cpanato merged commit dbb3160 into sigstore:main Jan 12, 2022
jauderho pushed a commit to jauderho/cosign-installer that referenced this pull request Feb 7, 2022
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants