Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add install with go support, fix flags #48

Merged
merged 1 commit into from Jan 18, 2022

Conversation

developer-guy
Copy link
Member

@developer-guy developer-guy commented Jan 7, 2022

Summary

feat: add install with go support, fix flags

Ticket Link

Fixes #45

Release Note

feat: add install with go support, fix flags

@developer-guy developer-guy force-pushed the feature/45 branch 4 times, most recently from bd56282 to 3b864a7 Compare January 7, 2022 14:11
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool!
can you add some doc in the readme?

@developer-guy
Copy link
Member Author

looks cool! can you add some doc in the readme?
@Dentrax and @necatican can you please help me with this folks? ✌️

action.yml Outdated Show resolved Hide resolved
@developer-guy
Copy link
Member Author

developer-guy commented Jan 9, 2022

looks cool! can you add some doc in the readme?

We(w/@Dentrax @necatican)'ve completed the documentation of our new feature. Thank you for bringing it to our attention @cpanato ✌️

Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment otherwise LGTM

action.yml Outdated Show resolved Hide resolved
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>
Co-authored-by: Necatican Yıldırım <necaticanyildirim@gmail.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @developer-guy :)

@cpanato cpanato merged commit 353e21c into sigstore:main Jan 18, 2022
jauderho pushed a commit to jauderho/cosign-installer that referenced this pull request Feb 7, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>
Co-authored-by: Necatican Yıldırım <necaticanyildirim@gmail.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>

Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>
Co-authored-by: Necatican Yıldırım <necaticanyildirim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide an option or specific version name to download cosign via go install command
3 participants