Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify permissions in workflow examples #46

Merged
merged 1 commit into from Jan 3, 2022

Conversation

JamieMagee
Copy link
Contributor

Summary

Simplifies the permissions in sample workflows.

What we really want is permissions: none-all, but that doesn't exist. Instead, explicitly setting the permissions for any scope, sets the permissions for all other scopes to none1

Ticket Link

N/A

Release Note

NONE

Footnotes

  1. https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#permissions

Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks like they changed becasue was read only before
thanks!!

@cpanato cpanato merged commit 12d5f6d into sigstore:main Jan 3, 2022
developer-guy pushed a commit to developer-guy/cosign-installer that referenced this pull request Jan 7, 2022
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@JamieMagee JamieMagee deleted the docs/simplify-permissions-setup branch February 7, 2022 05:04
jauderho pushed a commit to jauderho/cosign-installer that referenced this pull request Feb 7, 2022
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants