Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multiarch support for both linux and macOS runners #43

Merged
merged 30 commits into from Dec 29, 2021
Merged

add multiarch support for both linux and macOS runners #43

merged 30 commits into from Dec 29, 2021

Conversation

bobcallaway
Copy link
Member

@bobcallaway bobcallaway commented Dec 28, 2021 •
edited

Summary

Adds support for macOS runners as well as different processor architectures for linux and macOS. I will add windows support under a different PR.

Ticket Link

Part of #42

Release Note

  • Added support for macOS runners
  • Added support for different processor architectures for linux and macOS

@bobcallaway
print OS
ee57643 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
initial branch attempt
5f530c6 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
remove with
c8f351a 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
dont use input vars
b876320 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
use hashfiles as platform-agnostic sha256
f7dd31d 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
s/Darwin/macOS
914b2cd 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
os-specific sha
6413419 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix conditional
d52b638 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix conditional 2
77b6030 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
remove verbose logging
1e89849 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway bobcallaway changed the title add multiarch support for both linux and macOS runners WIP: add multiarch support for both linux and macOS runners Dec 28, 2021
@bobcallaway
add debugging
0311275 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
standardize file and signature download vars
710407f 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix semicolon
eaf95a9 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix signature path
68da01d 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix signature path again
69fa10d 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
download sig and release from google
c3bbb5b 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fetch signature from github instead of google
f4c7dfc 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix signature link
0115d73 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
add testing over macOS
7d286b1 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
narrow down testing a bit
2173a9d 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway bobcallaway changed the title WIP: add multiarch support for both linux and macOS runners add multiarch support for both linux and macOS runners Dec 29, 2021
@bobcallaway
update name
a126aa8 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@cpanato
Copy link
Member

cpanato commented Dec 29, 2021

asked @dlorenc to update the status check

cpanato
cpanato approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

@cpanato
Copy link
Member

cpanato commented Dec 29, 2021

maybe we can add some documentation in the readme saying that can be used for both mac and linux
I will work to give support to windows

@bobcallaway
update readme
07eb72f 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway bobcallaway linked an issue Dec 29, 2021 that may be closed by this pull request
Support Windows and Mac installation #42
Closed
@bobcallaway
clean up output during script
6701cb9 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix path
40dd2a6 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix quote
f11974a 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
add color to log messages
71776df 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
fix color
5ae0f25 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
add shopt
bbac964 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
switch to tput
3ed8f2f 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway
support color on linux and macos
42f71cd 
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@bobcallaway bobcallaway merged commit 8eebefc into sigstore:main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Windows and Mac installation
2 participants
@bobcallaway @cpanato