Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #29

Merged
merged 4 commits into from Oct 27, 2021
Merged

Readme updates #29

merged 4 commits into from Oct 27, 2021

Conversation

chrisns
Copy link
Contributor

@chrisns chrisns commented Oct 27, 2021

Summary

Hi,

There's a few things going on here, I'd be very happy to split into seperate PRs if you'd prefer please do let me know.

If you do approve I'd really appreciate if you could add the hacktoberfest label to this PR (or the repo).

Many thanks!

  • It appeared from the workflow's in the readme that the key was in the repo and no passphrase was used, which unless I'm missing something seems like a bad idea, so I've moved these to GitHub secrets.
  • I removed a few redundant params from the docker build step
  • I've used the docker_meta action to keep the image name and tags in one place rather than repeat it (DRY)
  • I've used the GitHub OIDC with the COSIGN_EXPERIMENTAL flag I did some proof of concept work on this here https://github.com/chrisns/cosign-keyless-demo

Release Note

Documentation updates to describe using GitHub OIDC and keeping key material in GitHub Secrets

Signed-off-by: Chris Nesbitt-Smith <chris@cns.me.uk>
Signed-off-by: Chris Nesbitt-Smith <chris@cns.me.uk>
Signed-off-by: Chris Nesbitt-Smith <chris@cns.me.uk>
Signed-off-by: Chris Nesbitt-Smith <chris@cns.me.uk>
@dekkagaijin dekkagaijin merged commit 57790db into sigstore:main Oct 27, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants