Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup files after validation #22

Merged
merged 1 commit into from Sep 2, 2021
Merged

cleanup files after validation #22

merged 1 commit into from Sep 2, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 1, 2021

cleanup files after validation, those are not needed after the install

Fixes: #21

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Copy link
Contributor

@mbestavros mbestavros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpanato cpanato merged commit 88d6a0f into sigstore:main Sep 2, 2021
@cpanato cpanato deleted the GH-21 branch September 2, 2021 07:33
@caarlos0
Copy link

caarlos0 commented Sep 3, 2021

this breaks my workflow: I have the pub key commited in the root of my repo, and using this action deletes it, which causes a dirty working tree...

@cpanato
Copy link
Member Author

cpanato commented Sep 3, 2021

got it @caarlos0 i will update the action to create the directory before to not mess with the root directory

@dirien
Copy link
Contributor

dirien commented Sep 3, 2021

@cpanato , why not download into the tmp folder of the worker?

On the otherhand, i think cosign should have http on verify-blob too? Similar to verify-docker

https://github.com/sigstore/cosign/blob/9906181a17ee51c9ead65379f15e28d53fdac013/cmd/cosign/cli/verify_dockerfile.go#L68

What do you think?

@cpanato
Copy link
Member Author

cpanato commented Sep 3, 2021

it have @dirien but we need to download the signature as well, but I will check

@dirien
Copy link
Contributor

dirien commented Sep 3, 2021

ah okay, i did not saw it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading sig and pubfile in project root leaves dirty git state
4 participants