Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All repos should not test everything against unrelated tests #121

Closed
lukehinds opened this issue Sep 5, 2022 · 14 comments
Closed

All repos should not test everything against unrelated tests #121

lukehinds opened this issue Sep 5, 2022 · 14 comments
Labels
good first issue Good for newcomers

Comments

@lukehinds
Copy link
Member

lukehinds commented Sep 5, 2022

A lot of repos are running unit / integration tests against changes such as a markdown edit.

This causes unnecessary use of resources and not in the interest of sustainable computing.

We should find some way to skip CI runs, perhaps based on extensions, .txt, .md

@lukehinds lukehinds added the good first issue Good for newcomers label Sep 5, 2022
@lukehinds
Copy link
Member Author

Something like this should do it:

on:
  push:
    paths-ignore:
      - '*.md'
      - 'docs/**'

@lukehinds
Copy link
Member Author

If you would like to work on this, just drop in a comment.

cc @cpanato , as this might need some wider coordination.

@n3k0m4
Copy link

n3k0m4 commented Sep 5, 2022

Hello,
I could possibly work on this.
CC-ing @cpanato as requested.

@deobieta
Copy link

deobieta commented Sep 5, 2022

Hi, I can work on this.
@cpanato

@cpanato
Copy link
Member

cpanato commented Sep 6, 2022

That sounds like a great idea.
Let's focus on the main repositories for now

  • cosign
  • rekor
  • fulcio
  • policy-controller
  • scaffolding

@n3k0m4 @deobieta, can you both split the work and work together? Thanks!

@deobieta
Copy link

deobieta commented Sep 6, 2022

@n3k0m4 Hi, if you want to make other repo combinations, it's fine by me.
Take your pick.
1: cosign, rekor
2: policy-controller, fulcio, scaffolding

@lukehinds
Copy link
Member Author

lukehinds commented Sep 6, 2022

awesome, thanks @deobieta / @n3k0m4 I recommend you both collaborate to work out an approach, you could always work together in a Google doc or whatever medium you like and me and @cpanato can comment and help out. Once you have an approach nailed down, we can then move to implementation. Last of all if you're both interested, this might make a nice article for blog.sigstore.dev.

@n3k0m4
Copy link

n3k0m4 commented Sep 11, 2022

I have made the Google Docs file for the changes.

Please, request the edit rights and notify me here to grant them.

If you have any concerns about my changes, you can put comments directly in the doc.

@deobieta @cpanato @lukehinds

@deobieta
Copy link

@lukehinds @cpanato Should actions run on forked repos?

@cpanato
Copy link
Member

cpanato commented Sep 16, 2022

@lukehinds @cpanato Should actions run on forked repos?

it can, but only the jobs that does not need access to GCP

@n3k0m4
Copy link

n3k0m4 commented Sep 16, 2022

@cpanato I opened a PR to Cosign, could you please check it out. If there is anything you would like me to change, I would be happy to fix it.

@cpanato
Copy link
Member

cpanato commented Sep 19, 2022

reopening, not all work is done :)

@deobieta
Copy link

@lukehinds @cpanato @n3k0m4 I left some notes in the Google Docs file about some approaches we can choose from to improve Github workflows use. Any help, comment or suggestion is welcomed. Thank you.

@lukehinds
Copy link
Member Author

closing this now, thanks for your help @deobieta @n3k0m4 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants