Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retry strictly invalid blocks #5771

Open
dapplion opened this issue May 13, 2024 · 0 comments
Open

Do not retry strictly invalid blocks #5771

dapplion opened this issue May 13, 2024 · 0 comments
Labels
Networking optimization Something to make Lighthouse run more efficiently.

Comments

@dapplion
Copy link
Collaborator

Description

Current stable will download and process a block that fails to process up to 5 times. If the block is deterministically / irrecoverably invalid (i.e. invalid state root), this strategy is wasteful.

We could:

  • Have a big match from BlockError to if error is irrecoverable (invalid state root) or recoverable (EL timeout)
  • Immediately drop lookups if irrecoverable, add block to failed chains, potentially forever.

CC: @AgeManning
@michaelsproul michaelsproul added optimization Something to make Lighthouse run more efficiently. Networking labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Networking optimization Something to make Lighthouse run more efficiently.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @dapplion