Do not request current child lookup peers #5724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
force-pushed
the
no-request-current-lookup-peers
branch
from
7269d79
to
c55dd1b
Compare
dapplion
changed the title
dapplion
force-pushed
the
no-request-current-lookup-peers
branch
from
c55dd1b
to
a356c75
Compare
michaelsproul
added a commit
that referenced
this pull request
May 7, 2024
Squashed commit of the following: commit a356c75 Author: dapplion <35266934+dapplion@users.noreply.github.com> Date: Tue May 7 00:50:54 2024 +0900 Do not request current child lookup peers
Open
dapplion
force-pushed
the
no-request-current-lookup-peers
branch
from
3073087
to
f30dd96
Compare
dapplion
commented
May 13, 2024
| } | ||
|
|
||
| #[test] | ||
| fn parent_block_and_blob_lookup_child_returned_first_blob_trigger() { |
There was a problem hiding this comment.
Not possible now, child is not requested until parent is imported
| } | ||
|
|
||
| #[test] | ||
| fn parent_block_and_blob_lookup_child_returned_first() { |
There was a problem hiding this comment.
Not possible now, child is not requested until parent is imported
| @@ -1287,19 +1317,6 @@ fn test_skip_creating_failed_parent_lookup() { | |||
| rig.expect_no_active_lookups(); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_skip_creating_failed_current_lookup() { | |||
There was a problem hiding this comment.
Not applicable anymore. A peer makes no claim that it has imported the child block, so it should not be downscored
| // Processing succeeds, now the rest of the chain should be sent for processing. | ||
| rig.parent_block_processed_imported(block_root); | ||
| rig.expect_parent_chain_process(); | ||
| rig.parent_chain_processed_success(block_root, &[]); | ||
| rig.expect_no_active_lookups(); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_parent_lookup_empty_response() { |
There was a problem hiding this comment.
Duplicated test, child and parent logic are the same now
dapplion
force-pushed
the
no-request-current-lookup-peers
branch
from
f30dd96
to
0b340b0
Compare
realbigsean
approved these changes
May 13, 2024
|
great simplification ! |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f37ffe4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Description of the problem ⬇️
Proposed Changes
Implement solution 1 from #5707
Todo
Closes #5707