Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Arc to LightClientFinalityUpdate in the LightClientServerCache #5578

Open
realbigsean opened this issue Apr 12, 2024 · 0 comments
Open

Add an Arc to LightClientFinalityUpdate in the LightClientServerCache #5578

realbigsean opened this issue Apr 12, 2024 · 0 comments

Comments

@realbigsean
Copy link
Member

Description

Identified by @dapplion, we crate a new Arc per LightClientFinalityUpdate response and clone on every call to get_latest_finality_update, when we could cache LightClientFinalityUpdate in an Arc in the LightClientServerCache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@realbigsean