Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Scrub span tags #1376

Open
tealwp opened this issue Sep 28, 2022 · 2 comments
Open

[Feature Request] Scrub span tags #1376

tealwp opened this issue Sep 28, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tealwp
Copy link

tealwp commented Sep 28, 2022

Adding an option to the instrumentation setup for databases to scrub any span attributes the user doesn't want sent with the trace. For example, we use custom built spans, alongside instrumented span events through postgres. Being able to remove the db statement tag from the span would be helpful, as the db statements can include personal information.

@MrAlias
Copy link
Contributor

MrAlias commented Sep 28, 2022

Would something like redact solve your issue?

@MrAlias MrAlias added the enhancement New feature or request label Sep 28, 2022
@tealwp
Copy link
Author

tealwp commented Sep 28, 2022

Ideally we'd be able to use the TracerProvider that distro.Run() sets up. Looks like to use redact we'd have to set up a NewTracerProvider. We may end up adding filters to the Collector, but I think there may be some benefit to adding config options to the initial instrumentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants