Fix overstrict protobuf pin #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anho-synthego
approved these changes
Oct 18, 2022
atoulme
approved these changes
Oct 21, 2022
|
@emaderer thank you! Do you know when this will land on pypi? |
|
@threewordphrase thanks for the update and your patience. Published https://pypi.org/project/signalfx/1.1.16/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix merged in #126, pinning
protobuf==3.20.1conflicts with (at least) google-api-core's recent pin on!=3.20.1.The original issue, #125 , appears to only be an issue with
protobuf>=4.21.0. This PR goes back to the old>pin with an additional constraint on<4.21.0. This should address the original issue without being unnecessarily restrictive and causing conflicts with other packages.Exact pinning by pip packages is problematic and discouraged. In this case, it breaks our
pip-compileworkflows as no acceptable version ofprotobufcan be found.