sfxclient/httpsink: use hex encoded string representation for loggabl… #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e headers if sha1 representation bytes is directly converted to string the output is garbage during logging. Instead use go built-in hex package EncodeToString() api
keitwb
approved these changes
Nov 19, 2021
|
that failure is due to docker box type being small and test cases not able to complete. This is taken care off in separate commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e headers
if sha1 representation bytes is directly converted to string the output is garbage during
logging. Instead use go built-in hex package EncodeToString() api