sfxclient: http sink upon error should not log all request headers #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubbyap
suggested changes
Nov 10, 2021
jgheewala
force-pushed
the
do_not_log_secure_headers
branch
5 times, most recently
from
98bcd13
to
ae454ae
Compare
secure credentials some headers in the request can potentially contain secure credentials. Added api loggableHeaders() which will extract out such headers that should not be logged sha them and write it back.
jgheewala
force-pushed
the
do_not_log_secure_headers
branch
from
ae454ae
to
dcaed6c
Compare
mdubbyap
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some headers in the request can potentially contain secure credentials.
Added api loggableHeaders() which will extract out such headers that
should not be logged.