add support to set up watcher via update function #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubbyap
reviewed
Oct 5, 2021
jgheewala
force-pushed
the
add_support_to_not_set_auth_watcher
branch
from
283ce0d
to
acbe3b9
Compare
If a user of ClientConfigChangerSink doesn't want auth watcher, then currently there is no way to do so. Hence, introduced a new API SetupSinkClientChanger which will accept init ClientConfigChangerSink with the authToken that is provided. If the users later on wants to update auth token it can be done using API AuthUpdate. Above changes give freedom to caller for not setting auth watcher which in some cases might not be required at all
jgheewala
force-pushed
the
add_support_to_not_set_auth_watcher
branch
from
acbe3b9
to
236aa86
Compare
mdubbyap
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.