Wrong name of .desktop file

[real-or-random]

• I have searched open and closed issues for duplicates
• I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

---

Bug Description

The intention of f790694 was to change the name of the desktop file to signal.desktop (because the dash in the previous name signal-desktop.desktop causes issues with mime registrations (#3602).

However, the new file is apparently not effective in the official Debian packages: When one downloads and inspects https://updates.signal.org/desktop/apt/pool/main/s/signal-desktop/signal-desktop_6.1.0_amd64.deb, the .desktop file in this package has name signal-desktop.desktop. This is an issue not only for Debian users. Also other distros use the .deb as a basis for their packages, e.g., an Arch Linux AUR package or a NixOS package.

This has been discovered in #5975 (comment) (which has correctly been closed because the original problem described in this issue has been resolved.)

Besides the dash being a risk due to #3602, this leads to issues on wayland where the window manager can't track windows properly. Ideally, X's WM_CLASS, wayland's app-id and the desktop file name should be the same.

One example of an issue is that the badge count stopped working for some users. This has been reported in #3387 (comment) (and as a comment to the commit itself) but the comment has been disregarded. Moreover, it has been reported in #4982 but this has been wrongly closed as a feature request. (It is not a feature request but a regression: apparently the badge count has worked before for the affected users.)

Steps to Reproduce

Operating System:

Linux

[FiSHYsolutions]

this is still an issue (using snap with xubuntu 22.04.3 lts):

bash:/var/lib/snapd/desktop/applications$ snap info signal-desktop | egrep 'stable|refresh|installed'
tracking:     latest/stable
refresh-date: heute um 23:06 CET
  latest/stable:    6.38.0 2023-11-14 (549) 181MB -
installed:          6.38.0            (549) 181MB -

bash:/var/lib/snapd/desktop/applications$ ls -l *signal*
-rwxr-xr-x 1 root root 470 Nov 15 23:06 signal-desktop_signal-desktop.desktop

bash:/var/lib/snapd/desktop/applications$ signal-desktop
.
.
.
Error org.freedesktop.DBus.Error.Failed: cannot find desktop file "/var/lib/snapd/desktop/applications/signal-desktop_signal.desktop"
Error org.freedesktop.DBus.Error.Failed: cannot find desktop file "/var/lib/snapd/desktop/applications/signal-desktop_signal.desktop"
.
.
.

bash:/var/lib/snapd/desktop/applications$ ls -l /var/lib/snapd/desktop/applications/signal-desktop_signal.desktop
ls: Zugriff auf '/var/lib/snapd/desktop/applications/signal-desktop_signal.desktop' nicht möglich: Datei oder Verzeichnis nicht gefunden
bash:/var/lib/snapd/desktop/applications$ echo $?
2