Allow more deployment statuses per Github docs #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticdev
approved these changes
Feb 15, 2022
staticdev
previously requested changes
Feb 15, 2022
There was a problem hiding this comment.
@greggilbert thanks for this PR. Would you please add your name to contributor's list and also the changes to changelog according to the instructions on https://github.com/sigmavirus24/github3.py/blob/main/CONTRIBUTING.rst
|
@staticdev Thanks for the note - I took a swing at it. Let me know! |
|
Thanks @greggilbert, now you need to run the test suite again since the formatting of the files you changed are now broken. Sorry for the inconvenience. |
greggilbert
force-pushed
the
feature/add-deployment-statuses
branch
from
9cd6440
to
ec906d0
Compare
greggilbert
force-pushed
the
feature/add-deployment-statuses
branch
from
37fb37c
to
f4314e8
Compare
for more information, see https://pre-commit.ci
|
@staticdev All good, hopefully I got it right this time. |
|
@staticdev pre-commit CI should auto-fix things it can for us |
sigmavirus24
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github Docs list more acceptable deployment statuses, so this updates the
create_statusfunction to allow those.