Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: expose mergeable attribute on ShortPullRequest #1005

Open
staticdev opened this issue Oct 7, 2020 · 4 comments
Open

Feature request: expose mergeable attribute on ShortPullRequest #1005

staticdev opened this issue Oct 7, 2020 · 4 comments

Comments

@staticdev
Copy link
Collaborator

Today if you dir a ShortPullRequest object you get:

['__class__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattr__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_api', '_boolean', '_build_url', '_delete', '_get', '_github_url', '_instance_or_null', '_iter', '_json', '_json_data', '_patch', '_post', '_put', '_ratelimit_resource', '_refresh_to', '_remove_none', '_repr', '_request', '_strptime', '_uniq', '_update_attributes', '_uri', '_uri_parse', 'as_dict', 'as_json', 'assignee', 'assignees', 'base', 'body', 'body_html', 'body_text', 'class_name', 'close', 'closed_at', 'comments_url', 'commits', 'commits_url', 'create_comment', 'create_review', 'create_review_comment', 'create_review_requests', 'created_at', 'delete_review_requests', 'diff', 'diff_url', 'etag', 'files', 'from_dict', 'from_json', 'head', 'html_url', 'id', 'is_merged', 'issue', 'issue_comments', 'issue_url', 'last_modified', 'links', 'merge', 'merge_commit_sha', 'merged_at', 'new_session', 'number', 'patch', 'patch_url', 'ratelimit_remaining', 'refresh', 'reopen', 'repository', 'requested_reviewers', 'requested_teams', 'review_comment_urlt', 'review_comments', 'review_comments_url', 'review_requests', 'reviews', 'session', 'state', 'statuses_url', 'title', 'update', 'updated_at', 'url', 'user']

@sigmavirus24
Copy link
Owner

99% certain the mergeable attribute from the API response is marked as being deprecated and unreliable, so I'd rather not

@staticdev
Copy link
Collaborator Author

staticdev commented Oct 8, 2020

@sigmavirus24
Copy link
Owner

Ah I was confusing mergeable with merge_commit_sha. Feel free to send a PR adding this. It should be pretty easy to complete, review, and merge.

@staticdev
Copy link
Collaborator Author

@sigmavirus24 I think that is it.. from what I saw in the API, the attribute is really mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants