Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go modules support #181

Merged
merged 6 commits into from
Mar 26, 2022
Merged

Go modules support #181

merged 6 commits into from
Mar 26, 2022

Conversation

jbendotnet
Copy link
Contributor

  • Add go.mod
  • Update vendored dependencies to include all dependent modules

@jbendotnet
Go Modules Support
dccc52a 
- Add go.mod
- Update vendored dependencies to include all dependent modules
@jbendotnet
Remove needless replace directive
2e17dcf
@jbendotnet
whitespace
8d3b0f2
@coveralls
Copy link

coveralls commented Jan 24, 2021 •
edited

Coverage Status

Coverage increased (+7.02%) to 100.0% when pulling c79eae9 on jbendotnet:gomodules-support into 24a351f on sideshow:master.

@jbendotnet jbendotnet changed the title Gomodules support Go modules support Jan 24, 2021
@jbendotnet
Copy link
Contributor Author

Hi @sideshow, this PR adds support for Go modules and vendors all dependencies, including those used in testing. This has required a change to the supported Go versions, as some dependencies were updated as part of that process. Hope useful, thanks.

@jdottori
Copy link

Hi @sideshow, would you like to merge this? I've seen several forks doing something similar and updating JWT dependency because of a DependaBot update. I can open a ticket to discuss the best approach there with a comparison of the existing ones.

@eljoth
Copy link

eljoth commented Mar 14, 2022 •
edited

Hey @jdottori I was just about to open the same PR and saw yours in the last moment!
@sideshow are there any updates on this? Really would appreciate go mod support.

I would recommend going with go 1.16 to stick with the go release policy (support of the last two major versions).

@sideshow
Copy link
Owner

Thanks for this PR! @jbendotnet
I'll update the JWT dependency and bump the go version in a seperate PR @jdottori @eljoth

@sideshow sideshow merged commit 2f839c8 into sideshow:master Mar 26, 2022
netrebel added a commit to life360/apns2 that referenced this pull request Jul 18, 2023
@netrebel @neilmorton
@chrishaines @jbendotnet @sideshow @moredure
Merge pull request #8 from life360/miguel/CCE-6006-apns2-upgrade-to-v…
408c8aa 
…0.23.0

* Add iOS 15 payload additions (sideshow#185)

* Add iOS 15 payload additions

- Add interruption-level to payload
 interruption-level options:
    - passive
    - active (default if none is passed to apns)
    - time-sensitive
    - critical (requires Apple entitlement)

- Add relevance-score to payload
relevance-score is a number between 0 and 1
The highest score gets featured in the notification summary.

* Update readme re iOS 15 features

* Fix documentation typo

Note that at the time of writing [Apple docs](https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification#2943360) have a typo, showing `time-senstive` as opposed to `time-sensitive`.

Testing has shown that the correct spelling `time-sensitive` does indeed work.

* Update builder.go

Alphabetically order keys in struct as per @Singwai suggestion.

* Allow relevance-score to be set to zero.

* Updated to single InterruptionLevel function

Co-authored-by: Chris Haines <chris.haines@braze.com>

* Go modules support (sideshow#181)

* Go Modules Support

* Replace Travis with Github Actions (sideshow#190)

* Replace Travis with Github Actions

* Fix context timeout error

* Add Github workflow badge

* Add coverage to actions

* Update jwt library (sideshow#191)

- Resolves sideshow#186
- Resolves sideshow#187
- Resolves sideshow#189

* Use NewReader instead of NewBuffer (sideshow#193)

* Add location push type (sideshow#194)

* Add location push type
* Fix Typo
* Add InvalidPushType reason error code

* Use type switch with assignment syntax (sideshow#196)

* Use POST http constant (sideshow#203)

* Use if type conditional (sideshow#198)

In that case if type is much simpler and look better.

* Simplify FromPemBytes conditional (sideshow#197)

- Simplify logic. strings.HasSuffix can check both for suffix and for equality

* Use NewRequestWithContext instead of nil checking (sideshow#200)

* Use appropriate type cast functions (sideshow#199)

* Use appropriate type cast functions
* avoid fmt usage

* Fix double pointer (sideshow#195)

* Refactor request/response variable names (sideshow#205)

r *Request is more consistent with n *Notification

* Feature/updated http2 transport (sideshow#209)

* Update http2 transport
* Add ReadIdleTimeout for ping frames
* Update defaults for TCP Keepalive

* Revert "CF-153: Updating Log to print issuedAt (#7)"

This reverts commit 69ea756.

* Revert "CF-133: Adding PushTypeLocation (#6)"

This reverts commit 3668879.

* Reverting Using int64 for timestamp (8fac21d)

* Changing module name

* gitignore idea directory

---------

Co-authored-by: Neil Morton <neil@progressconcepts.com>
Co-authored-by: Chris Haines <chris.haines@braze.com>
Co-authored-by: jbendotnet <2698840+jbendotnet@users.noreply.github.com>
Co-authored-by: Adam Jones <adam@digirati.co.nz>
Co-authored-by: Mikhail Faraponov <11322032+moredure@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbendotnet @coveralls @jdottori @eljoth @sideshow