Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all core Ruby types in job arguments #6208

Open
mperham opened this issue Feb 28, 2024 · 1 comment · May be fixed by #6209
Open

Support all core Ruby types in job arguments #6208

mperham opened this issue Feb 28, 2024 · 1 comment · May be fixed by #6209

Comments

@mperham
Copy link
Collaborator

mperham commented Feb 28, 2024

TIL that json/add/core exists and provides JSON serialization for Ruby core types (Date, Time, Symbol, etc).

My mantra of "native JSON types only" was entirely because I did not want to add custom serialization code to Sidekiq. With these extensions that mantra remains true but greatly improves the developer experience for all Sidekiq users.

Since the serialized job arguments can change before vs after, this issue may cause subtle compatibility issues. We need to be careful here.

@mperham
Copy link
Collaborator Author

mperham commented Feb 28, 2024

Blocked by flori/json#568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant