Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile.lock checked into repo makes handling diverse Rubies difficult #5114

Closed
petergoldstein opened this issue Jan 10, 2022 · 3 comments
Closed

Comments

@petergoldstein
Copy link
Contributor

Ruby version: 2.5-3.1
Rails version: N/A
Sidekiq

I'm trying to add Ruby 3.1 to the CI matrix, but I'm running into issues because the Gemfile.lock is checked into the repo. I'm not entirely sure why.

The problem is that there isn't a single version of Nokogiri that works with Ruby 2.5 and Ruby 3.1. Nokogiri 1.13 is the first version that supports Ruby 3.1 natively. But it requires Ruby 2.6+, so the Ruby 2.5 run fails on bundle install.

Can we remove the Gemfile.lock from the repo? That should fix the issue.

@mperham
Copy link
Collaborator

mperham commented Jan 10, 2022

I think I'd rather have 2.5 removed from the matrix. Support for 2.5 is not really important at this point.

@petergoldstein
Copy link
Contributor Author

Ok, I put up a PR (#5115) but it's not green. Psych changes are a problem for the Delayed Extensions features.

@petergoldstein
Copy link
Contributor Author

With the latest commit - that shifts the range of tested Rubies to 2.6-3.1 - I'll call this closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants