Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing 'exists?' command to redis as is; blind passthrough has been deprecated #4627

Closed
dbackeus opened this issue Jul 6, 2020 · 2 comments

Comments

@dbackeus
Copy link

dbackeus commented Jul 6, 2020

Ruby version: 2.6.5
Sidekiq / Pro / Enterprise version(s): Sidekiq version 6.1.0, Pro version 5.1.1

Appears that after fixing #4591 we now see a different recurring deprecation warning:

Passing 'exists?' command to redis as is; blind passthrough has been deprecated and will be removed in redis-namespace 2.0 (at /app/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.1.0/lib/sidekiq/launcher.rb:161:in `block (2 levels) in ❤')

While the previous warning could be silenced by explicitly setting Redis.exists_returns_integer = false we are not aware of any similar work around for this warning.

@mperham
Copy link
Collaborator

mperham commented Jul 6, 2020 via email

@dbackeus
Copy link
Author

dbackeus commented Jul 6, 2020

Right, I guess this is the issue to pay attention to: resque/redis-namespace#172

@mperham mperham closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants