-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warning from redis-rb #305
Comments
@jbwl This is Sidekiq issue, not scheduler one. And they have fixed it in the latest version, so you just need to bump the sidekiq gem |
The stacktrace in the issue description is from sidekiq, but I think the same issue is present in the scheduler codebase here |
I see that makes sense then |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I'm pretty sure this issue should remain open. In related news, it looks like fix is underway in #306. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still seems like this issue should remain open. 😇 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I'm still seeing these warnings, so it still seems like this issue should remain open. |
Please review #329 |
Fixed by #335 |
I am now getting deprecation warnings in my sidekiq.log
Redis#exists(key)
will return an Integer in redis-rb 4.3.exists?
returns a boolean, you should use it instead. To opt-in to the new behavior now you can set Redis.exists_returns_integer = true. To disable this message and keep the current (boolean) behaviour of 'exists' you can setRedis.exists_returns_integer = false
, but this option will be removed in 5.0.The text was updated successfully, but these errors were encountered: