Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

Highlite rendering a line too high #27

Closed
flamein opened this issue Sep 25, 2019 · 2 comments · Fixed by #40
Closed

Highlite rendering a line too high #27

flamein opened this issue Sep 25, 2019 · 2 comments · Fixed by #40
Assignees
@siavashs
Labels
bug
Milestone
v1.3.0

Comments

@flamein
Copy link
Contributor

flamein commented Sep 25, 2019

As reported by a user through Atlassian contact address
When using a code block like:

{code:c++|title=rmanshare/RIS/include/sharedComponents/PxrLightFilter.h|linenumbers|firstline=197|highlight=205-206}
// transform all points
RtInt res = lfCtx->Transform(RixShadingContext::k_AsPoints,
US_NULL, _coordSys,
numSamples, shadingCtxIndex,
xformedP, xformedP,
NULL, NULL);
if (res != 0)
{
std::cerr << "Transform from 'current' to '" << _coordSys.CStr()
<< "' did not work!" << std::endl;
}
{code}

It will render a highlite like this:
Screen Shot 2019-09-24 at 10 26 04 AM
@siavashs
Copy link
Owner

Opened a PR for upstream to fix this issue. PrismJS/prism#2235

@siavashs siavashs added the bug label Feb 27, 2020
@siavashs siavashs self-assigned this Feb 27, 2020
@siavashs siavashs mentioned this issue Feb 29, 2020
Closed
@siavashs siavashs added this to the v1.3.0 milestone Feb 29, 2020
@siavashs
Copy link
Owner

siavashs commented Mar 2, 2020

New PR by upstream PrismJS/prism#2237

siavashs added a commit that referenced this issue May 31, 2020
@siavashs
Temporary fix for line highlight plugin offset
71ad3aa 
Temporary fix for line highlight plugin offset until it's fixed by upstream.
Fixes #27
Upstream PR PrismJS/prism#2237
@siavashs siavashs mentioned this issue May 31, 2020
Merged
siavashs added a commit that referenced this issue May 31, 2020
@siavashs
Temporary fix for line highlight plugin offset (#40)
aa6f613 
Temporary fix for line highlight plugin offset until it's fixed by upstream.
Fixes #27
Upstream PR PrismJS/prism#2237
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siavashs siavashs

Labels
bug
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Temporary fix for line highlight plugin offset siavashs/Prism
2 participants
@siavashs @flamein