Add rel="noopener noreferrer" to links when openLinksInNewWindow is on. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jammerware
changed the title
|
You can read more about such vulnerability here: https://mathiasbynens.github.io/rel-noopener/ |
|
Thank you |
tivie
pushed a commit
that referenced
this pull request
Nov 2, 2019
Add rel="noreferrer" to links when openLinksInNewWindow is on. Also add noopener when openLinksInNewWindow is on. target="_blank" without also adding rel="noopener noreferrer" creates a vulnerability (since the site you're linking to has access to the window.opener by default. This adds rel="noopener noreferrer" to links generated by the makeHtml converter when openLinksInNewWindow is true. Closes #670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how well this fits in with your goals for the project, but my understanding is that using
target="_blank"without also addingrel="noopener noreferrer"creates a vulnerability (since the site you're linking to has access to thewindow.openerby default. This pull addsrel="noopener noreferrer"to links generated by themakeHtmlconverter whenopenLinksInNewWindowistrue.Let me know if I dun goofed or if I can do anything else to help. Thanks for making Showdown!