Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghMentions does not work with username having dots #574

Closed
davidsandoz opened this issue Aug 22, 2018 · 8 comments · May be fixed by coderbyheart/contentful-static-website-generator#6
Closed
Assignees

Comments

@davidsandoz
Copy link

Description

In GitLab, dots are allowed in usernames (unlike in GitHub). When using ghMentions with ghMentionsLink, if the given username contains a dot, the link is made only with what is before the dot.

Input

@john.doe

With the following showdown options:

{
    ghMentions: true,
    ghMentionsLink: 'https://gitlab.example.com/{u}',
}

Expected output

<a href="https://gitlab.example.com/john.doe>@john.doe</a>

Actual output

<a href="https://gitlab.example.com/john>@john</a>.doe
@tivie tivie self-assigned this Sep 14, 2018
@tivie
Copy link
Member

tivie commented Sep 14, 2018

Github only allows dashes in the middle of the name.

@davidsandoz
Copy link
Author

@tivie You're right. But I'm using showdown with GitLab.

@tivie
Copy link
Member

tivie commented Sep 14, 2018

I will make showdown allow dashes, underscores and dots in the middle of the username, since that seems a valid usecase scenario

@tivie tivie closed this as completed in 2ba0075 Sep 14, 2018
@tivie
Copy link
Member

tivie commented Sep 14, 2018

Should be fixed now

@davidsandoz
Copy link
Author

Awesome, thanks! Do you have an idea when will the next release happen?

@tivie
Copy link
Member

tivie commented Sep 14, 2018

Soonish I hope. Version 2.0-alpha will be the next release.

@tivie
Copy link
Member

tivie commented Sep 15, 2018


Donate Click here to lend your support to: ShowdownJS website and testing platform and make a donation at paypal.com

As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money.
If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated and help us continue to develop this awesome library.

@davidsandoz
Copy link
Author

Done 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants