Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

literalMidWordUnderscores causes full sentences to be bolded #544

Closed
rachel-church opened this issue Jun 1, 2018 · 1 comment · May be fixed by qsays/Awesome-Design-Tools#1, coderbyheart/contentful-static-website-generator#6 or pocket-dragon/pocket-dragon.github.io#14
Closed

literalMidWordUnderscores causes full sentences to be bolded #544

rachel-church opened this issue Jun 1, 2018 · 1 comment · May be fixed by qsays/Awesome-Design-Tools#1, coderbyheart/contentful-static-website-generator#6 or pocket-dragon/pocket-dragon.github.io#14
Assignees
@tivie
Labels
bug

Comments

@rachel-church
Copy link

I would expect the behavior of literalMidWordUnderscores to only affect underscores attached to non-space characters.

Example:
some text with__underscores__in middle where __ is used without spaces between words.

Actual Behavior:
If literalMidWordUnderscores is true then all text between two separate bolded words gets bolded.

__Once upon a time__, there was a little girl named __Goldilocks__.
Expected: Once upon a time, there was a little girl named Goldilocks.

screen shot 2018-06-01 at 9 28 56 am
@tivie tivie self-assigned this Jun 5, 2018
@tivie tivie added the bug label Jun 5, 2018
@tivie
Copy link
Member

tivie commented Jun 5, 2018 •
edited

bug introduced in 1.6.4

VladimirV99 added a commit to VladimirV99/showdown that referenced this issue Oct 21, 2018
@VladimirV99
fix(italicsAndBold): Make italicsAndBold lazy
c858abb 
fix italicsAndBold if literalMidwordUnderscores option is enabled
it should end at the nearest closing underscores, not the furthest

Closes showdownjs#544
@VladimirV99 VladimirV99 mentioned this issue Oct 21, 2018
Merged
@tivie tivie closed this as completed in 4378abb Nov 9, 2018
tivie pushed a commit that referenced this issue Nov 10, 2018
@VladimirV99 @tivie
fix(italicsAndBold): Make italicsAndBold lazy (#608)
0c6f345 
fix italicsAndBold if literalMidwordUnderscores option is enabled
it should end at the nearest closing underscores, not the furthest

Closes #544
tivie pushed a commit that referenced this issue Nov 10, 2018
@VladimirV99 @tivie
fix(italicsAndBold): Make italicsAndBold lazy (#608)
5c0d67e 
fix italicsAndBold if literalMidwordUnderscores option is enabled
it should end at the nearest closing underscores, not the furthest

Closes #544
@snyk-bot snyk-bot mentioned this issue Jan 24, 2020
Open
This was referenced Mar 9, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tivie tivie

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@tivie @rachel-church