Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple parentheses () in url link is not parsed correctly #534

Closed
fbucek opened this issue May 15, 2018 · 4 comments
Closed

Multiple parentheses () in url link is not parsed correctly #534

fbucek opened this issue May 15, 2018 · 4 comments
Assignees
@tivie
Labels
bug

Comments

@fbucek
Copy link

fbucek commented May 15, 2018

Description:

Url link with multiple () in url path does not work correctly. Single parentheses () in url is parsed correctly.

Input

[Jira issue filter](https://bugreports.qt.io/browse/QTBUG-68277?jql=project%20in%20(QTBUG%2C%20QBS)%20AND%20issuetype%20in%20(Bug%2C%20Epic)%20AND%20status%20%3D%20Open)

Expected output

Basically what Github does, Github parse this link correctly: Jira issue filter

Actual output:

Jira issue filter%20AND%20status%20%3D%20Open)

Results form Showdown demo
@tivie tivie self-assigned this Jun 5, 2018
@tivie tivie added the bug label Jun 5, 2018
@tivie
Copy link
Member

tivie commented Jun 5, 2018 •
edited

Confirmed. Related to other link parser bugs.

@tivie
Copy link
Member

tivie commented Sep 25, 2018

#355

tivie added a commit that referenced this issue Sep 25, 2018
@tivie
fix(links): a number of issues with links subparser
d3ebff7 
This is a major refactor of the links subparser, previously known as anchors subparser.

Closes #355, #534

BREAKING CHANGE: `excludeTrailingPunctuationFromURLs` option was removed. This is now the default behavior
@tivie
Copy link
Member

tivie commented Sep 25, 2018

Should be fixed now.

Donate Click here to lend your support to: ShowdownJS website and testing platform and make a donation at paypal.com

As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money.
If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated and help us continue to develop this awesome library.

@tivie tivie closed this as completed Nov 10, 2018
@RushikeshPatange
Copy link

RushikeshPatange commented Aug 10, 2023 •
edited

@fbucek It appears that the issue you're experiencing is still unresolved. I'm facing a similar problem in my case #986 . During my exploration, I discovered that using a backslash \ before the closing parenthesis (the inner ones) provides the correct expected result.

So, for instance, your input could be modified as follows:

Please take a note on \ before closing parenthesis (the inner ones) 👀

Input

[Jira issue filter](https://bugreports.qt.io/browse/QTBUG-68277?jql=project%20in%20(QTBUG%2C%20QBS\)%20AND%20issuetype%20in%20(Bug%2C%20Epic)%20AND%20status%20%3D%20Open)

[Jira issue filter](https://bugreports.qt.io/browse/QTBUG-68277?jql=project%20in%20(QTBUG%2C%20QBS)%20AND%20issuetype%20in%20(Bug%2C%20Epic\)%20AND%20status%20%3D%20Open)

Result

Jira issue filter

I have tried it with Live Demo, PTAL @fbucek, @tivie and @SyntaxRules .Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tivie tivie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tivie @fbucek @RushikeshPatange