Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading space breaks code block #523

Closed
ewalpole opened this issue Apr 26, 2018 · 2 comments · May be fixed by coderbyheart/contentful-static-website-generator#6
Closed

Leading space breaks code block #523

ewalpole opened this issue Apr 26, 2018 · 2 comments · May be fixed by coderbyheart/contentful-static-website-generator#6
Assignees
Labels

Comments

@ewalpole
Copy link

Leading space on code block before the 3 back ticks breaks the code block rendering correctly.
This does not break in github so should not break in showdown.

Example Input:

 ```javascript
var test = test;
...

Broken Output:

 ```javascript
var test = test;
...

Expected Output:

var test = test;
...

Please let me know if you need more detail or examples. This happens frequently when our customers create their markdown files. They see that their code blocks work in github and then they are broken on conversion with showdown. It's confusing for them.

Thanks!

@tivie tivie self-assigned this May 7, 2018
@tivie tivie added the bug label May 7, 2018
@tivie
Copy link
Member

tivie commented May 7, 2018

verified

@tivie
Copy link
Member

tivie commented Sep 15, 2018

Should be fixed now.
@ewalpole can you please test it?


Donate Click here to lend your support to: ShowdownJS website and testing platform and make a donation at paypal.com

As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money.
If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated and help us continue to develop this awesome library.

@tivie tivie closed this as completed in 6259f37 Sep 15, 2018
tivie added a commit that referenced this issue Oct 16, 2018
Now GFM Code Blocks can have up to 3 spaces before the backticks

Closes #523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants