Separate async error from original error in onError handling #204
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original error needs to be kept separately from any potential errors that might occur while processing the onError hooks. This was already done in one place where `err2` was being used. If all onError callbacks complete successfully then `async.eachSeries` calls its callback without an error value. One way to repro this problem is to set up a `beforeRequest` hook that sets `request.url = null`. Artillery then errors in a spot where it tries to access the original error but actually accesses the non-existent async error.
|
Good catch, thanks @jordan-brough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original error needs to be kept separately from any potential errors that
might occur while processing the onError hooks.
This was already done in one place where
err2was being used.If all onError callbacks complete successfully then
async.eachSeriescalls itscallback without an error value.
One way to repro this problem is to set up a
beforeRequesthook that setsrequest.url = null. Artillery then errors in a spot where it tries to accessthe original error but actually accesses the non-existent async error.
NOTE: It does seem like something ought to pay attention to any async errors. That
might be good to tackle in a separate PR though?