Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow retry when making patches or releases #1572

Open
1 task
Aqudi opened this issue Dec 14, 2023 · 2 comments
Open
1 task

feat: Allow retry when making patches or releases #1572

Aqudi opened this issue Dec 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Aqudi
Copy link

Aqudi commented Dec 14, 2023

Greetings to the Shorebird Development Team,

Firstly, I want to extend my heartfelt thanks for developing such a useful and efficient tool!

Description

When creating patches or releases using the shorebird_cli, the process requires confirmation to proceed (Would you like to continue? (y/N)). Currently, if any character other than 'y' or 'N' is entered, the process aborts immediately. This results in a significant take time to rebuild. I propose adding a feature to allow retrying the confirmation step without having to restart the entire build process.

Requirements

  • Ensure that if a character other than 'y' or 'N' is entered, the user is prompted again for confirmation.

Additional Context

Additional Context Below is an example of the current process where an accidental input leads to an abort, requiring a complete rebuild:

shorebird patch android
...
Would you like to continue? (y/N) No                                                                                                              
Aborting.

This feature would enhance the developer experience by reducing unnecessary delays and frustration.

@bryanoltman
Copy link
Contributor

This is a good idea. I filed felangel/mason#1202 with the CLI library we use, which is where the first bit of work for this would take place.

@Aqudi
Copy link
Author

Aqudi commented Jan 7, 2024

This is a good idea. I filed felangel/mason#1202 with the CLI library we use, which is where the first bit of work for this would take place.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Punted
Status: Punted
Development

No branches or pull requests

3 participants