Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: docker-compose V1 is deprecated and useless for people with newly installed docker compose V2 version #2960

Open
thirdknown opened this issue Jan 3, 2024 · 2 comments

Comments

@thirdknown
Copy link
Contributor

I have installed the new version V2 of Docker Compose on my PC and I could not use docker-compose in Makefile anymore. So I was thinking the solution thinking that there are people working with me, who have V1 version. So on the project I created Makefile-v2 file with only docker compose, which is used by me by typing make -f Makefile-v2 <makefile target> (this solution is not ideally, I know). The second solution is let the only Makefile file and duplicate make targets (for both groups of people - with docker-compose and docker compose). The third solution could be to make (Linux) alias docker-compose for docker compose maybe. There could be more solutions of the problem.

I don't know the correct and ideal solution, but I know that this problem will must be solved, because there will be more people with V2 version (not only me) in the future and there still will be some people with old V1 version.

BTW - the content of current Makefile https://github.com/shopsys/shopsys/blob/14.0/Makefile is mix of docker-compose (V1, can't be installed, deprecated) and docker compose (V2, the only version to be newly installed).

@thirdknown
Copy link
Contributor Author

One of the solutions is to install Docker Compose standalone - https://docs.docker.com/compose/install/standalone/. Then both docker-compose and docker compose work.

@techi602
Copy link
Contributor

JFYI when running install.sh or docker-compose in GitHub Actions can also fail because GitHub have recently removed docker-compose from ubuntu-latest images

Changing to docker compose solves this problem.

https://github.com/shopsys/shopsys/blob/15.0/project-base/scripts/install.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants