extract translation misbehaves when locale is provided along with parameters

[grossmannmartin]

Describe the bug

It is possible to pass locale and translation domain to the t function.

The method header is like

/**
 * @param string $id
 * @param array $parameters
 * @param string|null $domain
 * @param string|null $locale
 * @return string
 */
function t($id, array $parameters = [], $domain = null, $locale = null)

Following calls works fine

t('my string');
t('my %adjective% string', ['%adjective%' => 'awesome']);
t('my string', locale: 'cs');
t('my string, locale: $locale);

However following throws an exception on php phing translations-dump command

t('my %adjective% string', ['%adjective%' => 'awesome'], locale: $locale);
// Can only extract the message ID or message domain from a scalar, concatenated string or "\Shopsys\FrameworkBundle\Component\Translation\Translator" class constant, but got "PhpParser\Node\Expr\Variable".

// third parameter is not actually a translation domain, but named argument (fourth)

t('my %adjective% string', ['%adjective%' => 'awesome'], null, $locale);
// Can only extract the message ID or message domain from a scalar, concatenated string or "\Shopsys\FrameworkBundle\Component\Translation\Translator" class constant, but got "PhpParser\Node\Expr\ConstFetch".

// null is not accepted even though it's the default value. Maybe domain should not be nullable and Translator::DEFAULT_DOMAIN should be the default value

Maybe it would be nice to check following (I suspect it will not extract into proper translation domain file)

t('my string', domain: 'another-translation-domain')

Expected behavior

No error is raised 🙂