Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected product without name as variant don't show name in form #2562

Open
grossmannmartin opened this issue Feb 15, 2023 · 0 comments
Open

Comments

@grossmannmartin
Copy link
Member

Describe the bug

When a product does not have filled name in the administration language, an empty row is displayed in the list when this product is selected as a variant in the create variant form.

To Reproduce

  1. Remove the name of the product in the admin language
  2. See "Product name in the default language is not entered" in the product list (first image)
  3. Click on Create variant button
  4. Select this product as a variant
  5. See the empty row in the variants section (second image)

Snímek obrazovky 2023-02-15 v 8 42 12

Snímek obrazovky 2023-02-15 v 8 42 24

Expected behavior

Ideally, the same filter should be used for rendering the variant name as it's used in the product list. So when I need to override this display name, I can do it in one place.

@grossmannmartin grossmannmartin changed the title Selected product as variant Selected product as variant without name don't show name in form Feb 15, 2023
@grossmannmartin grossmannmartin changed the title Selected product as variant without name don't show name in form Selected product without name as variant don't show name in form Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants