Add implementation of natural exponent function (Taylor, Hull-Abraham) #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains an implementation of two approaches for calculating the natural exponent of decimal: Hull-Abraham algorithm and Taylor series expansion.
Hull-Abraham implementation is based on implementation from cockroachdb/apd. Their implementation can be found here: apd/context.go. Many thanks to Cockroach devs who created such an amazing library :3
Additionally, the
NumDigitsmethod was added, as such functionality was needed for the first algorithm.I know both algorithms can be optimized, but I will work on this in the future. As it's better to have slow, but working new functionality, than having nothing in my opinion. NumDigits method needs the most attention here I guess.