Fix incorrect calculation of RoundUp/RoundDown because value after rescaling was ignored #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ups, I think I forgot about this case. Thank you for the fix @lovung ! |
|
@mwoss I have already added 4 test cases. Do you want me to add more? Because I think 4 are enough. |
|
I didn't notice those test cases yesterday, sorry. :D |
mwoss
approved these changes
Jan 17, 2021
|
@mwoss I have updated the description. Could you take a look? Thank you so much. |
mwoss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current implementation uses the
rescalemethod before deciding to Add/Sub 1 for the rescaled value.But, it will be wrong in the case the rescaled value equals the original value.
Fix
Compare the value after rescaling.