Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RoundUp and RoundDown methods #196

Merged
merged 3 commits into from Dec 11, 2020
Merged

Implement RoundUp and RoundDown methods #196

merged 3 commits into from Dec 11, 2020

Conversation

mwoss
Copy link
Member

@mwoss mwoss commented Dec 11, 2020

Implementation of methods requested by community in #191.
Many thanks to @da0x for providing the test cases for RoundUp method!

Benchamarks:

goos: windows
goarch: amd64
pkg: github.com/shopspring/decimal
BenchmarkDecimal_RoundUp-8   	 5381696	       216 ns/op	     160 B/op	       7 allocs/op
BenchmarkDecimal_RoundDown-8   	 5404801	       228 ns/op	     160 B/op	       7 allocs/op

@mwoss mwoss requested a review from njason December 11, 2020 01:15
@lovung
Copy link
Contributor

lovung commented Dec 11, 2020 •
edited

Many thanks ❤️

njason
njason approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@njason njason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brawo!

@njason njason merged commit 8bd41ac into master Dec 11, 2020
@njason njason deleted the round-up-and-down branch December 11, 2020 18:41
@da0x da0x mentioned this pull request Dec 15, 2020
Closed
@mwoss mwoss mentioned this pull request Jan 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njason njason njason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwoss @lovung @njason