Implement IsInteger method #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njason
approved these changes
Jun 30, 2020
|
Yes, it's a pretty rare case. If I would see any performance benefits by introducing this case I would add it along with new Power implementation |
fairyhunter13
added a commit
to fairyhunter13/decimal
that referenced
this pull request
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains an implementation of the IsInteger method that I'm using in WIP implementation of the decimal power method. I'm introducing this functionality in separate PR as new Power implementation would be enough difficult to review and I don't want to hinders it anymore.
I experimented a bit with performance here and I decided to go with the most straight forward implementation (simple abs function, simple checks) as the improvement was almost not visible at all, but they make implementation tricky to understand.