Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating Known Values for Trigonometry Methods #313

Open
isnotwonky opened this issue Feb 24, 2023 · 0 comments
Open

Generating Known Values for Trigonometry Methods #313

isnotwonky opened this issue Feb 24, 2023 · 0 comments

Comments

@isnotwonky
Copy link

isnotwonky commented Feb 24, 2023

I noticed a number of known values are generated every time you run a trig. function (but not all of them). Wouldn't it be more efficient if all known values were generated once only?

Also, isn't using NewFromFloat() starting from a less accurate number? Would it be better to use RequireFromString() to generate known values?

This might be wonky of me, but as for the value of pi, instead of ...
pi := NewFromFloat(3.14159265358979323846264338327950288419716939937510582097494459)

We could have ...
var pi = RequireFromString("3.14159265358979323846264338327950288419716939937510582097494459230781640628620899862803482534211706798214")

(106 digits from https://oeis.org/A000796/constant)

@isnotwonky isnotwonky changed the title Trigonometry Generating Known Values for Trigonometry Methods Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant