Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better explanation on how to use the rbi.yml config #97

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Better explanation on how to use the rbi.yml config #97

merged 1 commit into from
Mar 10, 2022

Conversation

Morriar
Copy link
Contributor

@Morriar Morriar commented Feb 14, 2022 •
edited

@Morriar Morriar added the documentation Improvements or additions to documentation label Feb 14, 2022
@Morriar Morriar requested a review from a team February 14, 2022 17:53
@Morriar Morriar self-assigned this Feb 14, 2022
KaanOzkan
KaanOzkan approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@KaanOzkan KaanOzkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should close that issue with this PR, skimmed over the latest comment and they're still not having a smooth experience with this suggestion

@Morriar
Better explanation on how to use the rbi.yml config
6f1a829 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar merged commit 2fce9e3 into main Mar 10, 2022
@Morriar Morriar deleted the at-readme-rbi branch March 10, 2022 17:06
@shopify-shipit shopify-shipit bot temporarily deployed to production April 28, 2022 15:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@vinistock vinistock vinistock approved these changes

Assignees

@Morriar Morriar

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Morriar @KaanOzkan @vinistock